Skip to content

Refactor DescriptorData initialization to use identifier_encoded #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dk-emag merged 1 commit into from
May 11, 2026
Merged

Refactor DescriptorData initialization to use identifier_encoded #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aas_standard_parser/classes/descriptor_json_helper_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ def __init__(self, href: str):
class DescriptorData:
"""Class to represent the descriptor data structure."""

def __init__(self, identifier: str):
def __init__(self, identifier_encoded: str):
"""Initialize the DescriptorData with the given descriptor data."""
self.identifier: str = identifier
self.identifier_encoded: str = identifier_encoded
self.identifier: str = ""
self.endpoints: list[dict] = []
self.description: dict = {}
self.display_name: dict = {}
Expand Down
7 changes: 4 additions & 3 deletions aas_standard_parser/descriptor_json_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,21 @@ def parse_descriptor(descriptor_data: dict) -> DescriptorData | None:
:param descriptor_data: The descriptor data containing endpoints.
:return: A DescriptorData object containing parsed descriptor information.
"""
identifier = descriptor_data.get("id", "")
identifier_encoded = descriptor_data.get("id", "")

if not identifier:
if not identifier_encoded:
logger.warning(f"Descriptor data missing 'id' field: {descriptor_data}")
return None

descriptor = DescriptorData(identifier)
descriptor = DescriptorData(identifier_encoded)
descriptor.endpoints = descriptor_data.get("endpoints", [])
descriptor.description = descriptor_data.get("description", {})
descriptor.display_name = descriptor_data.get("displayName", {})
descriptor.assetKind = descriptor_data.get("assetKind", "")
descriptor.id_short = descriptor_data.get("idShort", "")
descriptor.semantic_id = descriptor_data.get("semanticId", {})
descriptor.supplementary_semantic_ids = descriptor_data.get("supplementarySemanticIds", [])
descriptor.identifier = decode_base_64(identifier_encoded)

return descriptor

Expand Down