rebase - #23
Merged
Merged
Conversation
Enhance the ElementValue class to include a condition for handling boolean values. When the Value is a boolean, it is converted to a lowercase string representation. This improves the overall handling of different data types alongside existing support for double and float.
Enhanced the ValueScopeConverter to check for boolean values when processing string tokens. If the expected data type is boolean, the string is parsed accordingly; otherwise, it defaults to returning the string value as an ElementValue.
The processing of values for Boolean properties has been corrected when these are provided as strings via the REST API. The return format for Boolean values via the REST API has been improved (upper- / lower-case).
Modified the WriteMetadata method to include a check for null or empty values for the IdShort property of ISubmodelElement. This change prevents writing an empty string for idShort in the JSON output. The properties kind, modelType, and category remain unchanged.
…de distribution files
feat: add changelog generation and enhance release notes in CI workflow
Introduce a new `QualifiersConverter` class to handle the serialization and deserialization of `Qualifier` objects. Update `SubmodelElementConverter.cs` and `ValueScopeConverter.cs` to utilize this converter for `qualifiers` and `annotations`, enhancing the overall JSON output structure.
Improve qualifiers serialization
Updated SubmodelController to check for null values in fileElement.Value.Value. If null, fileName is assigned from file.FileName, enhancing code robustness and preventing potential null reference exceptions.
Handle null case for fileElement.Value.Value
- Updated variable declarations to use `var` for improved readability. - Added logic to delete existing files associated with `fileElement` before uploading a new file to prevent conflicts. - Changed file creation to use `await using` for better asynchronous performance.
Refactored the code to use `var` for variable declarations, enhancing readability. Added a line to reset `fileElement.Value.Value` to an empty string before returning an `Ok()` response, indicating a reset after processing.
Fix and improve attachment handling
Changed the server URL from `http://0.0.0.0:5088` to `http://+:5043` to allow listening on all network interfaces at port 5043.
Changed the assignment of `fileElement.Value.Value` in `SubmodelController.cs` from an empty string (`string.Empty`) to `null`. This improves clarity in representing the absence of a value and enhances consistency in handling null values.
…mprove API response handling
…e submodel elements
…th XSD data type definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebase