Conversation
chore: remove stale docs and benchmarks
`evict_idle_repos` only iterates `self.last_access`. `warmup_repo` deliberately did not write to `last_access` (its comment said "warmup is not a real query, idle timer should only reset on real query"), but the side effect was that warmed-but-never-queried repos never appeared in `last_access` at all and therefore stayed warm forever \u2014 holding open LMDB environments and embedder state. Visible symptom in the TUI: aliases like KRKA.Aprimo, DPS, BAYR.Aprimo showed status `warm` with `Last Tool Call = -` indefinitely, while aliases that had been touched (e.g. aprimo_mcp, investing) correctly transitioned to `closed` after the idle window. Fix: have `warmup_repo` start the idle timer at warmup. A real query still resets the timer via `touch_access`. A repo that is never queried gets evicted after the idle timeout, which is the desired behaviour.
- warmup_repo now calls touch_access so warmed-but-never-queried repos appear in last_access and get evicted by the idle reaper. Without this, background-warmed aliases stayed Warm forever. - is_quit_key drops the Ctrl-C arm. crossterm's raw mode delivers Ctrl-C as a key event (ENABLE_PROCESSED_INPUT off), so treating it as quit tore down the whole serve from a stray terminal Ctrl-C. Use q only.
…locks fix(serve): idle timer + TUI Ctrl-C; SAFETY comments on LMDB unsafe blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.0.81. See CHANGELOG.md for details.
Highlights:
Warmstate on KRKA.Aprimo, DPS, BAYR.Aprimo, etc.)qto quitunsafeenv-open blocksAudit notes: cargo check + clippy
-D warningsclean, 740 tests pass.