Create a separate "Flutter Presubmits" checkrun for the unified checkrun flow.#5022
Open
eyebrowsoffire wants to merge 2 commits intoflutter:mainfrom
Open
Create a separate "Flutter Presubmits" checkrun for the unified checkrun flow.#5022eyebrowsoffire wants to merge 2 commits intoflutter:mainfrom
eyebrowsoffire wants to merge 2 commits intoflutter:mainfrom
Conversation
…run flow. This allows us to add "Flutter Presubmits" to the required checks for release candidate branches as well, and have a less confusing name (since release candidate branches don't use the merge queue). Merge Queue Guard is still created but immediately completed when unified checkruns are created, because this is a required check. Similarly, "Flutter Presubmits" is always created, and if the unified checkruns are disabled, we immediately complete it as well. This allows us to make this a required check for the `master` branch and the release candidate branches as well.
jtmcdole
approved these changes
Apr 15, 2026
Comment on lines
842
to
+865
| @@ -837,8 +848,43 @@ $s | |||
| title: Config.kMergeQueueLockName, | |||
| summary: kMergeQueueLockDescription, | |||
| ), | |||
| detailsUrl: detailsUrl, | |||
| detailsUrl: isUnifiedCheckRun ? null : detailsUrl, | |||
| ); | |||
|
|
|||
| final flutterPresubmits = await _githubChecksService.githubChecksUtil | |||
| .createCheckRun( | |||
| _config, | |||
| slug, | |||
| headSha, | |||
| Config.kFlutterPresubmitsName, | |||
| output: const CheckRunOutput( | |||
| title: Config.kFlutterPresubmitsName, | |||
| summary: kFlutterPresubmitsDescription, | |||
| ), | |||
| detailsUrl: isUnifiedCheckRun ? detailsUrl : null, | |||
| ); | |||
Member
There was a problem hiding this comment.
Do we need to create both? Is the idea that we'll have "MQG" and "PSG"?
| slug, | ||
| mqGuard, | ||
| status: CheckRunStatus.completed, | ||
| conclusion: CheckRunConclusion.success, |
Member
There was a problem hiding this comment.
Prefer using neutral or skipped?
| slug, | ||
| flutterPresubmits, | ||
| status: CheckRunStatus.completed, | ||
| conclusion: CheckRunConclusion.success, |
jtmcdole
reviewed
Apr 15, 2026
Member
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
Left some comments - mostly nits.
jtmcdole
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to add "Flutter Presubmits" to the required checks for release candidate branches as well, and have a less confusing name (since release candidate branches don't use the merge queue).
Merge Queue Guard is still created but immediately completed when unified checkruns are created, because this is a required check.
Similarly, "Flutter Presubmits" is always created, and if the unified checkruns are disabled, we immediately complete it as well. This allows us to make this a required check for the
masterbranch and the release candidate branches as well.