Fix failing DevTools integration tests by excluding semantics on some tooltips#9660
Open
elliette wants to merge 4 commits intoflutter:masterfrom
Open
Fix failing DevTools integration tests by excluding semantics on some tooltips#9660elliette wants to merge 4 commits intoflutter:masterfrom
elliette wants to merge 4 commits intoflutter:masterfrom
Conversation
elliette
changed the title
srawlins
approved these changes
Feb 11, 2026
Contributor
srawlins
left a comment
srawlins
left a comment
There was a problem hiding this comment.
Very nice! Awkward that we have to change impl code; hopefully that issue in flutter/flutter gets resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9643
Fixes #9639
Fixes #9641
Fixes #9645
Fixes #9646
This PR excludes semantics for the DevTools tooltips that were causing our integration tests to fail, with TODOs to remove the
ExcludeSemanticscalls once flutter/flutter#161630 is fixed.Note: Because I didn't want to
ExcludeSemanticsin theDevToolsClearableTextFieldindevtools_app_shared, I have created a new text fieldDevToolsTextFieldwhich I'm then using to exclude semantics for the clear button indevtools_app.