Skip to content

Fixes future warning for awaiting Future returns in async bodies inside try blocks #9664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FMorschel wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fixes future warning for awaiting Future returns in async bodies inside try blocks #9664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class EvalOnDartLibrary extends DisposableController
if (result is ErrorRef) {
throw result;
}
return result as FutureOr<InstanceRef?>;
return await result as FutureOr<InstanceRef?>;
} catch (e, stack) {
if (shouldLogError) {
_handleError('$e - $expression', stack);
Expand Down Expand Up @@ -242,7 +242,7 @@ class EvalOnDartLibrary extends DisposableController
if (result is ErrorRef) {
throw result;
}
return result as FutureOr<InstanceRef?>;
return await result as FutureOr<InstanceRef?>;
} catch (e, stack) {
if (shouldLogError) {
_handleError('$e - $name', stack);
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_shared/test/helpers/helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Future<TestDtdConnectionInfo> startDtd() async {
}
});

return completer.future
return await completer.future
.timeout(dtdConnectTimeout, onTimeout: onFailure)
.then((value) async {
await dtdStoutSubscription?.cancel();
Expand Down
Loading