-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[mustache_template] Fix auto-generated specification tests, run with dart test
#11056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0f57ba0
Test runner script, including unsupported optional spec handling
jslater89 c93d33b
Move spec tests into a Dart test for packages infrastructure
jslater89 ccbe6e3
Don't duplicate tests in mustache_test.dart
jslater89 5902256
Test README documenting specification source/update process
jslater89 31e5051
Package specs for non-dart:io consumption, unskip passing test
jslater89 ec7e457
Run dart format
jslater89 ce2a56c
Remove unused dart:io import
jslater89 beb03db
Remove invalid test from feature_test.dart
jslater89 0ad64c5
Refactor exception tests to use throwsA
jslater89 187c8f9
Correct test cases for certain invalid tags in lenient mode
jslater89 6441425
Only keep generated Dart files from download_spec.sh
jslater89 6d95882
Object destructuring for specs map entries
jslater89 ff6d3a6
Format feature_test.dart
jslater89 0690a5a
Download_spec Dart script in place of download_spec.sh
jslater89 eca7dbe
Apply suggestions from code review
jslater89 2f18f33
Merge branch 'main' into spec-test-runner
jslater89 d96b408
test/README changes for specification metadata
jslater89 3b96a7b
Lower camel case for unsupported specs constant
jslater89 8369768
Merge branch 'main' into spec-test-runner
bkonyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| test/spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Test Structure | ||
|
|
||
| ## Specifications | ||
|
|
||
| `mustache_test.dart` and `mustache_specs.dart` generate tests for all mustache specifications, | ||
| except for those disabled by `mustache_test.dart`'s `unsupportedSpecs` constant. | ||
| `dart test mustache_test.dart` runs all of the generated tests. | ||
|
|
||
| Each generated specification file contains the mustache commit hash from which it was generated, | ||
| and the date when it was generated. | ||
|
|
||
| ### Updating specifications | ||
|
|
||
| From the package root, run `dart run tool/download_spec.dart` to pull new definitions from the | ||
| mustache repository into `test/specs/`. | ||
|
|
||
| ## Features | ||
|
|
||
| Standalone or handwritten tests regarding template output go in `feature_test.dart`. | ||
|
|
||
| ## Parser | ||
|
jslater89 marked this conversation as resolved.
|
||
|
|
||
| Tests for the template language parser go in `parser_test.dart`. | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.