[quick_actions] Switch to Kotlin Pigeon#11507
[quick_actions] Switch to Kotlin Pigeon#11507stuartmorgan-g wants to merge 2 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: code refactor with no semantic change |
There was a problem hiding this comment.
Code Review
This pull request migrates the quick_actions_android package to use Kotlin Pigeon for its internal implementation. The changes involve updating the build configuration to support Kotlin, replacing Java-generated Pigeon files with Kotlin versions, and refactoring the Android plugin implementation to align with the new API. Feedback points out an invalid Kotlin version in the build script and an unsafe unchecked cast in the utility code.
| companion object { | ||
| @JvmStatic | ||
| fun <T> success(value: T, callback: Any) { | ||
| val castedCallback: (Result<T>) -> Unit = callback as (Result<T>) -> Unit |
Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:
Part of flutter/flutter#158287
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2