Conversation
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
examples/triggers/notifications.py
Outdated
| on_phase=( | ||
| "FAILED", | ||
| "TIMED OUT", | ||
| ), |
There was a problem hiding this comment.
Is there some way to pass in list of enums instead of strings?
There was a problem hiding this comment.
enums we avoid as you have to import so we use literals. these are literals
There was a problem hiding this comment.
I can make them enums, no problem though
There was a problem hiding this comment.
I am thinking, if we do this, then all phases will be in a common model for all of user facing apis and we can then use them everywhere
There was a problem hiding this comment.
Can we re-use the phase literals as defined here? https://github.com/flyteorg/flyte-sdk/blob/main/src/flyte/remote/_run.py#L21-L23 (i.e. lower-cased)
There was a problem hiding this comment.
Ohh ya - but I think I will
Move them to a common place
There was a problem hiding this comment.
I moved them to a common place now, will update PR
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
| name="hourly", | ||
| auto_activate=True, | ||
| automation=flyte.Cron("* * * * *"), | ||
| notifications=flyte.notify.Slack( |
There was a problem hiding this comment.
-
Is this saying that notifications will ONLY be sent for failed triggered runs?
What if I want to configure notifications even for runs that are manually created(via Web or CLI). Lets say, its an important workflow on prod domain and everybody in the team must be aware about failures even If I'm the author of the run and I saw the failure. -
Are the notifications only attached to individual tasks?
do we want to allow configuring notifications for entire domain(prod), project+domain(<important_project> on prod) or maybe project+domain+task_regex?
What if I want to configure your notifications once, without repeating same configs on multiple task definitions?
As a follow up for 1 and 2, should notifications be a separate SDK entity in which you can configure multiple matching criteria independently? project, domain, task_regex, triggered vs manual, maybe others in future?
There was a problem hiding this comment.
I would like it to be possible to notify at the organization, domain, and project-domain levels as this is a frequent request we got in v1 over the past few years. People want to be able to notify on any failure in the prod domain, for instance. I don't know that this makes sense to include in the SDK, though - I feel like this makes sense in the UI for sure, as well as the API/CLI (which can be used by a terraform provider).
There was a problem hiding this comment.
+1 to Votta. With scoping for now to be triggered runs only
| ), | ||
| flyte.notify.Webhook( | ||
| on_phase="SUCCEEDED", | ||
| headers={"Content-Type": "application/json"}, |
There was a problem hiding this comment.
- should webhooks URLs be accessible without any auth credentials? if not, what should be the DevUX for customer to provide credentials for his webhook securely to Union? and I guess Union notifications service(workers) should be able to read those secure credentials during the notification delivery.
- same question about Slack API. Not familiar with it, but do we need some token to hit the API? who and how will provide this token to us?
There was a problem hiding this comment.
I think we will stick to unauthenticated webhooks (or more specifically, webhooks which embed the auth into the webhook itself)
| flyte.notify.Email( | ||
| on_phase="SUCCEEDED", | ||
| subject="Hello world! from {task.name}", | ||
| body="Hello world! from {task.name}", |
There was a problem hiding this comment.
just want to double check the DevUX here: if I want the same email template to be sent for all my failed tasks with some variables like <task_name>, <domain>, <project>, etc. , I can simply store this template in a Python variable, and then re-use it in all Email notification configs?
not sure what email provider are we going to use or if its critical right now, but, for example, AWS SES supports both sending raw emails with entire HTML body and sending emails with template id, that refers to previously uploaded template.
There was a problem hiding this comment.
Just render on client side. As this may change all the time
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
5 participants
No description provided.