This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Draft
Conversation
Signed-off-by: Daniel Rammer <daniel@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 58.85% 60.32% +1.47%
==========================================
Files 170 170
Lines 16068 13155 -2913
==========================================
- Hits 9457 7936 -1521
+ Misses 5777 4385 -1392
Partials 834 834
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
To allow re-use of literal casting in other repositories this PR refactors the code into flyteidl.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA