This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Conversation
…ary (#554) * Add migration to turn `parent_id` column into `bigint` only if necessary Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Migrations to handle the change of `parent_id` column in `node_executions` table Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Add unit test Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * More coverage Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Create index outside transaction Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
EngHabu,
eapolinario,
hamersaw,
katrogan,
kumare3 and
pmahindrakar-oss
as code owners
Codecov Report
@@ Coverage Diff @@
## release-v1.1.88 #561 +/- ##
===================================================
- Coverage 58.85% 58.48% -0.38%
===================================================
Files 170 170
Lines 16068 16184 +116
===================================================
+ Hits 9457 9465 +8
- Misses 5777 5883 +106
- Partials 834 836 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This is a PR to pull in the column fixes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/