feat: change string length before collapse in json view#844
Open
xwk1246 wants to merge 1 commit intoflyteorg:masterfrom
Open
feat: change string length before collapse in json view#844xwk1246 wants to merge 1 commit intoflyteorg:masterfrom
xwk1246 wants to merge 1 commit intoflyteorg:masterfrom
Conversation
Signed-off-by: xwk1246 <xwk1246@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 63.17% 63.17%
=======================================
Files 528 528
Lines 13449 13449
Branches 2567 2567
=======================================
Hits 8497 8497
Misses 4952 4952 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Feb 23, 2024
Member
|
@jsonporter could we merge this? before: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Most S3 storage links are longer than 80 characters and would collapse. Changing the length to 100 will prevent the links from collapsing.
Type
Are all requirements met?
Complete description
Change the length before collapse to 100.
Follow-up issue
NA