feat(log-panel): Add a button to show log panel in popup window#857
Open
MortalHappiness wants to merge 1 commit intoflyteorg:masterfrom
Open
feat(log-panel): Add a button to show log panel in popup window#857MortalHappiness wants to merge 1 commit intoflyteorg:masterfrom
MortalHappiness wants to merge 1 commit intoflyteorg:masterfrom
Conversation
88e9f57 to
7a69c70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
+ Coverage 54.74% 55.30% +0.55%
==========================================
Files 578 564 -14
Lines 15153 14627 -526
Branches 2767 2667 -100
==========================================
- Hits 8296 8089 -207
+ Misses 6857 6538 -319 ☔ View full report in Codecov by Sentry. |
Resolves: flyteorg/flyte#5108 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
7a69c70 to
aebdc40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Add a button to show log panel in popup window
Type
Are all requirements met?
Complete description
log-popup.mp4
Tracking Issue
Resolves: flyteorg/flyte#5108
Follow-up issue
NA