This repository was archived by the owner on May 31, 2024. It is now read-only.
Fix flyteadmin port in flytectl config init#400
Open
eapolinario wants to merge 1 commit intomasterfrom
Open
Conversation
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 66.57% 67.35% +0.77%
==========================================
Files 145 145
Lines 6271 5235 -1036
==========================================
- Hits 4175 3526 -649
+ Misses 1816 1429 -387
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 133 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pingsutw
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix the flyteadmin port by
flytectl config initto match the one required by demo clusterType
Are all requirements met?
Complete description
The flyteadmin port used in the demo cluster is 30080, so users who have rely on
flytectl config initto generate a valid config file should be left with a config file that reflects that.Tracking Issue
flyteorg/flyte#3461
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/