Merged
Conversation
added 2 commits
December 8, 2023 12:57
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
neverett
commented
Dec 8, 2023
neverett
commented
Dec 8, 2023
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
9 tasks
neverett
commented
Dec 11, 2023
neverett
commented
Dec 11, 2023
neverett
commented
Dec 11, 2023
added 5 commits
December 11, 2023 09:27
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
3 tasks
Signed-off-by: nikki everett <nikki@union.ai>
Contributor
|
The integration test issue doesn't look like it's related to this PR I'm okay with merging this and tackling that issue in a separate PR |
added 6 commits
December 12, 2023 18:51
Signed-off-by: nikki everett <nikki@union.ai>
…ary requirements, small edits to example python script Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
added 2 commits
December 13, 2023 10:13
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
eapolinario
reviewed
Jan 2, 2024
Collaborator
eapolinario
left a comment
eapolinario
left a comment
There was a problem hiding this comment.
Overall the imagespec example looks pretty good, but I don't understand why we're also adding a hello-world example.
basic-template-imagespec/{{cookiecuter.project_name}}/workflows/example.py
Outdated
Show resolved
Hide resolved
basic-template-imagespec/{{cookiecuter.project_name}}/workflows/example.py
Show resolved
Hide resolved
basic-template-imagespec/{{cookiecuter.project_name}}/workflows/example.py
Show resolved
Hide resolved
templates.json
Outdated
| {"template_name": "wine-classification", "workflow_name": "training_workflow"} | ||
| {"template_name": "wine-classification", "workflow_name": "training_workflow"}, | ||
| {"template_name": "basic-template-imagespec", "workflow_name": "wf"}, | ||
| {"template_name": "hello_world", "workflow_name": "hello_world_wf"} |
Collaborator
There was a problem hiding this comment.
not sure why we're adding the hello-world example, but the template name is not matching (hello_world instead of hello-world).
Contributor
Author
There was a problem hiding this comment.
I added ahello-world example in response to this feedback on the new onboarding docs, and went into a bit more detail on my changes here. I'll update the template name, thanks for flagging!
added 4 commits
January 2, 2024 13:39
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: nikki everett <nikki@union.ai>
|
Congrats on merging your first pull request! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic template that uses ImageSpec, based on the simple example template in #40.
Context
We need a template that uses ImageSpec for the updated onboarding docs (specifically, the new "Creating a Flyte project" and "Flyte project components" pages.) Per the discussion in today's OSS retro planning meeting, it sounds like a long-term plan we may want to consider (with input from appropriate stakeholders) may be to move the content-specific examples we want to keep (bayesian-optimization, mnist-training) from this repo to flytesnacks, remove the wine-classification example, and make the templates in this repo focused on project patterns instead (single cluster deployment, multi-cluster deployment, Dockerfile for those who need to use that instead of ImageSpec).
TODO after merging this PR
pyflyte initing a new project directorybasic-example-dockerfile