Merged
Conversation
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
Future-Outlier,
cosmicBboy,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
pingsutw
previously approved these changes
Jul 8, 2024
…e_jinija_v2 Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
EngHabu
approved these changes
Jul 9, 2024
pingsutw
approved these changes
Jul 9, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to flyteorg/flyte#4418 and #2413
Why are the changes needed?
This PR reduces the number of dependencies in
flytekit.What changes were proposed in this pull request?
This removes the Jinja2 dependency from flytekit and uses the
stringsinstead.How was this patch tested?
I build an image with
make build-devand confirmed that the deck renders.