[BUG] sync_node_executions fails for workflows with BranchNode#3274
Open
machichima wants to merge 7 commits intoflyteorg:masterfrom
Open
[BUG] sync_node_executions fails for workflows with BranchNode#3274machichima wants to merge 7 commits intoflyteorg:masterfrom
machichima wants to merge 7 commits intoflyteorg:masterfrom
Conversation
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
-e Signed-off-by: machichima <nary12321@gmail.com>
machichima
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3274 +/- ##
==========================================
- Coverage 83.35% 76.44% -6.92%
==========================================
Files 347 245 -102
Lines 28791 23657 -5134
Branches 2960 2961 +1
==========================================
- Hits 23999 18084 -5915
- Misses 3956 4711 +755
- Partials 836 862 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machichima
changed the title
-e Signed-off-by: machichima <nary12321@gmail.com>
pingsutw
reviewed
Jan 9, 2026
Comment on lines
+2614
to
+2617
| if execution._node.branch_node is not None: | ||
| logger.info( | ||
| "Skipping branch node execution for now - branch nodes will " "not have inputs and outputs filled in" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Part of flyteorg/flyte#6490
Why are the changes needed?
When using flytekit's
FlyteRemoteand callingremote.waiton an execution of a workflow that contains aBranchNode, we will get following error:What changes were proposed in this pull request?
In some cases, the
execution.metadata.is_parent_nodefor branch node is not True, which lead to the block without managing branch node separately. Moving the logic handling branch node before checkingis_parent_nodeto handle both is and is not branch node casesHow was this patch tested?
integration test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the handling of branch nodes in Flytekit's execution logic, fixing a bug related to their management and ensuring they are handled correctly regardless of their parent node status. It introduces a new conditional workflow and tests to improve the library's robustness for complex workflows by preventing errors associated with missing attributes in branch nodes.