Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/lib/ast/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,12 @@ pub enum ItemKind<'src> {
#[derive(Debug)]
pub struct ConstItem<'src> {
pub override_policy: OverridePolicy,
pub type_level: TypeLevel,
pub binder: Ident<'src>,
pub generics: Generics<'src>,
pub ty: Ty<'src>,
pub body: Option<Expr<'src>>,
}

#[derive(Debug)]
pub enum TypeLevel {
Yes,
No,
}

#[derive(Debug)]
pub struct ConstBlockItem<'src> {
pub body: BlockExpr<'src>,
Expand Down
6 changes: 1 addition & 5 deletions src/lib/fmter/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,9 @@ impl Fmt for (ast::ItemKind<'_>, Vec<ast::Attr<'_, ast::InnerAttrStyle>>) {

impl Fmt for ast::ConstItem<'_> {
fn fmt(self, cx: &mut Cx<'_>) {
let Self { override_policy, type_level: tyness, binder, generics, ty, body } = self;
let Self { override_policy, binder, generics, ty, body } = self;

override_policy.trailing_space().fmt(cx);
match tyness {
ast::TypeLevel::Yes => fmt!(cx, "type "),
ast::TypeLevel::No => {}
}
fmt!(cx, "const ");
binder.fmt(cx);
if !generics.params.is_empty() {
Expand Down
28 changes: 8 additions & 20 deletions src/lib/parser/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ impl<'src> Parser<'_, '_, 'src> {
| TokenKind::Final
| TokenKind::Macro
| TokenKind::Struct
| TokenKind::Trait => return true,
| TokenKind::Trait
| TokenKind::Type => return true,
_ => {}
}

Expand Down Expand Up @@ -162,25 +163,12 @@ impl<'src> Parser<'_, '_, 'src> {
// FIXME: Provide more targeted diagnostics if the qualifiers don't make sense.
match qualifiers.as_mut_slice() {
[] => {}
[Qualifier::Type(_)] => return self.fin_parse_ty_alias_item(override_policy),
[Qualifier::Const(span)] if self.consume(TokenKind::OpenCurlyBracket) => {
self.feature(Feature::const_block_items, *span);
return self.fin_parse_const_block_item();
}
[qualifiers @ .., Qualifier::Const(_)] => {
let (type_level, qualifiers) = match qualifiers {
[Qualifier::Type(span), qualifiers @ ..] => {
// FIXME: There's also feature gate `mgca_type_const_syntax`.
self.feature(Feature::min_generic_const_args, *span);
(ast::TypeLevel::Yes, qualifiers)
}
_ => (ast::TypeLevel::No, qualifiers),
};
if !qualifiers.is_empty() {
self.error(ErrorKind::InvalidItemPrefix, start.until(self.token.span));
}

return self.fin_parse_const_item(override_policy, type_level);
[Qualifier::Const(_)] => {
return self.fin_parse_const_item(override_policy);
}
// `crate` can't be a qualifier itself because it may also begin paths & it's not worth the look-ahead.
[Qualifier::Extern(None)] if self.consume(TokenKind::Crate) => {
Expand Down Expand Up @@ -313,6 +301,10 @@ impl<'src> Parser<'_, '_, 'src> {
self.advance();
return self.fin_parse_struct_item();
}
TokenKind::Type => {
self.advance();
return self.fin_parse_ty_alias_item(override_policy);
}
TokenKind::Use => {
self.advance();
return self.fin_parse_use_item();
Expand Down Expand Up @@ -390,7 +382,6 @@ impl<'src> Parser<'_, '_, 'src> {
TokenKind::Mod => Qualifier::Mod,
TokenKind::Static => Qualifier::Static,
TokenKind::Trait => Qualifier::Trait,
TokenKind::Type => Qualifier::Type(self.token.span),
TokenKind::Unsafe if self.peek(1).kind != TokenKind::OpenCurlyBracket => {
Qualifier::Unsafe(self.token.span)
}
Expand All @@ -405,7 +396,6 @@ impl<'src> Parser<'_, '_, 'src> {
fn fin_parse_const_item(
&mut self,
override_policy: ast::OverridePolicy,
type_level: ast::TypeLevel,
) -> Result<ast::ItemKind<'src>> {
let (binder, _) = self.parse_common_ident_or(TokenKind::Underscore)?;
let params = self
Expand All @@ -422,7 +412,6 @@ impl<'src> Parser<'_, '_, 'src> {

Ok(ast::ItemKind::Const(Box::new(ast::ConstItem {
override_policy,
type_level,
binder,
generics: ast::Generics { params, preds },
ty,
Expand Down Expand Up @@ -1254,7 +1243,6 @@ enum Qualifier<'src> {
Safe,
Static,
Trait,
Type(Span),
Unsafe(Span),
}

Expand Down
4 changes: 0 additions & 4 deletions src/lib/parser/test/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ safe fn f() {}
safe static X: ();
static safe: ();
trait Trait {}
type const F: ();
type const safe: (); // [!]
unsafe auto trait Trait {}
unsafe extern "C" fn f() {}
unsafe extern "C" {}
Expand Down Expand Up @@ -338,8 +336,6 @@ safe fn f() {}
safe static X: ();
static safe: ();
trait Trait {}
type const F: ();
type const safe: (); // [!]
unsafe auto trait Trait {}
unsafe extern "C" fn f() {}
unsafe extern "C" {}
Expand Down