feat: add feedback command #13
Open
+1,519
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmueller
force-pushed
the
codex/add-scribae-feedback-command
branch
from
11f977e to
cc6d4b3
Compare
- Extract `truncate` function to io_utils.py (was duplicated in 3 files) - Extract `Reporter` type alias to io_utils.py (was duplicated in 6 files) - Add `apply_optional_settings` helper to llm.py for model config - Add --seed and --top-p CLI options to feedback command - Add unit tests for truncate, Reporter, and seed/top-p propagation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fmueller
force-pushed
the
codex/add-scribae-feedback-command
branch
from
3490fb0 to
aa61a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
--noteis provided.Description
src/scribae/prompts/feedback.pyto drive a structured, JSON-only feedback agent with an explicit schema.src/scribae/feedback.py, including context preparation, section extraction, prompt rendering, LLM invocation, andmd/jsonrenderers.scribae feedbackinsrc/scribae/feedback_cli.pyand wire the command into the CLI viasrc/scribae/main.py, supporting--body,--brief,--note,--section,--focus,--format,--out,--out-dir,--dry-run,--save-prompt,--project,--language, and--modelflags.tests/unit/feedback_cli_test.pyandtests/fixtures/body_multi_section.mdto cover Markdown/JSON outputs, dry-run prompt printing, and section scoping.Testing
uv run ruff check src testsand linting passed without issues.uv run pytestand the test suite completed successfully with120 passed.uv run mypy src testsin this environment but the invocation did not complete (interrupted); recommend running to completion in CI/locally.scribae feedback(Markdown/JSON/dry-run/section behavior) were executed as part of the test run and passed.Codex Task