This repository was archived by the owner on Feb 1, 2021. It is now read-only.
Conversation
…++ classes FOGL-2773: Allow service name with double quotes escaped in FogLAMP C++ classes
pintomax
added
the
DO NOT MERGE YET
pintomax
removed
the
DO NOT MERGE YET
Unit tests updated
Singhal-Vaibhav
suggested changes
May 2, 2019
Contributor
Singhal-Vaibhav
left a comment
Singhal-Vaibhav
left a comment
There was a problem hiding this comment.
Please refer JIRA for change request
Always check result of addCategory
MarkRiddoch
approved these changes
May 29, 2019
Contributor
MarkRiddoch
left a comment
MarkRiddoch
left a comment
There was a problem hiding this comment.
LGTM - having " in names is a slightly questionable thing anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…++ classes
FOGL-2773: Allow service name with double quotes escaped in FogLAMP C++ classes