FOLIO-4418 FOLIO-4126 Extract sonar logic #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
commented
Jan 16, 2026
Comment on lines
-119
to
-120
| - name: Report whether doing Sonar scan | ||
| run: echo "do-sonar-scan=${{ inputs.do-sonar-scan }}" | tee -a $GITHUB_STEP_SUMMARY |
Member
Author
There was a problem hiding this comment.
I didn't copy this one over as I felt the actions UI was sufficient here (it'll show the entire step skipped if its disabled, and rerunning with debug will explicitly show that it was skipped because inputs.do-sonar-scan was disabled. If you'd still like it printed, that could be moved to the main one or in the report-testing-variables
ncovercash
force-pushed
the
FOLIO-4126-extract-sonar
branch
from
c3facc3 to
96062c7
Compare
ncovercash
commented
Jan 16, 2026
Comment on lines
+163
to
+170
| - name: Upload additional build artifacts | ||
| uses: actions/upload-artifact@v6 | ||
| with: | ||
| name: build-artifacts | ||
| path: | | ||
| target | ||
| !target/**/*.jar | ||
| !target/apidocs |
Member
Author
There was a problem hiding this comment.
Sonar needs target/classes, target/generated-sources, and whatever other magic stuff gets dumped in target depending on the module's configuration, so we upload it all. This is <2MB in my testing, so little overhead (and is a great debugging resource for devs, too).
was fetch-depth=0 for sonar
dcrossleyau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96 but only extracting sonar logic for parallel running.
Here's what this looks like:
Note that typically this would group sonar and uploading apidocs together, but apidocs also relies on
version-number, so they technically have different dependencies and are shown separately.