Replace deprecated gethostbyaddr() with getnameinfo()#57
Merged
folkertvanheusden merged 1 commit intoJan 2, 2026
Merged
Conversation
The `gethostbyaddr()` function is deprecated (POSIX.1-2008) and has several issues: - Not thread-safe (uses static internal buffer) - Not IPv6 ready (only works with `AF_INET`) Replaced with `getnameinfo()` in: - cv.c: CONVTYPE_IP4TOHOST conversion - mt.c: syslog sender IP resolution Note: While `getnameinfo()` supports IPv6, the current implementation still only handles IPv4 addresses (matching the original functionality). Full IPv6 support would require additional changes. This resolves rpmlint warnings about deprecated network functions. Fixes folkertvanheusden#12 Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gethostbyaddr()function is deprecated (POSIX.1-2008) and has several issues:AF_INET)Replaced with
getnameinfo()in:Note: While
getnameinfo()supports IPv6, the current implementation still only handles IPv4 addresses (matching the original functionality). Full IPv6 support would require additional changes.This resolves rpmlint warnings about deprecated network functions.
Fixes #12