Fix self-intersecting output in clean_extreme_slopes_outer/inner#37
Merged
Merged
Conversation
The in-place vertex removal/relocation in the _1/_2 passes could produce a self-intersecting shape on degenerate "extreme slope" inputs (e.g. thin needle shapes). Track the corner triangles each pass cuts away, and if the final shape self-intersects, robustly reconstruct it by unioning (outer) or differencing (inner) those triangles against the original shape, mirroring the fallback used in simplify(). Add CleanExtremeSlopesInnerTest with inline and JSON-loaded cases, including a real repro that used to throw and now collapses to an empty result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-place vertex removal/relocation in the _1/_2 passes could produce a self-intersecting shape on degenerate "extreme slope" inputs (e.g. thin needle shapes). Track the corner triangles each pass cuts away, and if the final shape self-intersects, robustly reconstruct it by unioning (outer) or differencing (inner) those triangles against the original shape, mirroring the fallback used in simplify().
Add CleanExtremeSlopesInnerTest with inline and JSON-loaded cases, including a real repro that used to throw and now collapses to an empty result.