Improve CSS URL extraction and robustness in getBackgroundImages #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
getComputedBackgroundImagesto correctly parseurl()values with single quotes, double quotes, or no quotes at all.\1) to ensure matching opening and closing quotes, preventing truncation in complex strings.getComputedStyle.url()functions for better compatibility with different browser engines.Why:
The previous implementation failed on standard CSS patterns like
url('...')or unquoted Data URIs, and was prone to breaking when encountering parentheses within the URL path.