refactor: rename WebApplication on-disk directory from webapplications to uiBundles @W-21674925@#1719
Open
deepu-mungamuri94 wants to merge 1 commit intoforcedotcom:mainfrom
Conversation
…s to uiBundles @W-21674925@ Aligns the SDR metadata registry and all test fixtures with the recent rename in plugin-templates (webapp → ui-bundle), where the user-facing folder constant changed from `webapplications` to `uiBundles`. Changes: - metadataRegistry.json: update `directoryName` and `directoryNames` map key for the webapplication type from "webapplications" to "uiBundles" - Rename test fixture directories: originalMdapi, snapshot expected outputs, and NUT testProj source directories - Update hardcoded "webapplications" path strings in test TypeScript files: filePathGenerator.test.ts, webApplicationValidation.test.ts, webApplications.nut.ts, webApplicationsDeploy.nut.ts, metadataApiDeploy.test.ts Intentionally left unchanged: - Registry id/name/suffix (webapplication / WebApplication) — Salesforce API names - Adapter strategy string, class names, TypeScript file names — internal SDR identifiers - File suffixes (.webapplication-meta.xml, webapplication.json) — Salesforce API surface - Metadata API server-response fileName strings in deploy test (server-side concern) Made-with: Cursor
binzywu
reviewed
Mar 28, 2026
| "appTemplates": "appframeworktemplatebundle", | ||
| "lightningTypes": "lightningtypebundle", | ||
| "webapplications": "webapplication" | ||
| "uiBundles": "webapplication" |
binzywu
reviewed
Mar 28, 2026
| expect(zip.file('webapplications/HappyApp/HappyApp.webapplication-meta.xml')).to.exist; | ||
| expect(zip.file('webapplications/HappyApp/webapplication.json')).to.exist; | ||
| expect(zip.file('webapplications/HappyApp/src/index.html')).to.exist; | ||
| expect(zip.file('uiBundles/HappyApp/HappyApp.webapplication-meta.xml')).to.exist; |
binzywu
reviewed
Mar 28, 2026
| const zip = await JSZip.loadAsync(zipBuffer as Buffer); | ||
| zip.remove('webapplications/HappyApp/webapplication.json'); | ||
| zip.remove('webapplications/HappyApp/src/index.html'); | ||
| zip.remove('uiBundles/HappyApp/webapplication.json'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the SDR metadata registry and all test fixtures with the recent rename in plugin-templates (webapp → ui-bundle), where the user-facing folder constant changed from
webapplicationstouiBundles.What does this PR do?
directoryNameanddirectoryNamesmap key for the webapplication type from "webapplications" to "uiBundles"Intentionally left unchanged:
What issues does this PR fix or reference?
@W-21674925@