Remove window name argument; current drivers ignore or fail with current#93
Open
alexharpin wants to merge 1 commit into
Open
Conversation
Author
|
The Selenium 2 driver also defaults to "current" when the name argument is null, so maintains the behaviour of this driver as well (even though it's less likely to be used as it doesn't support the new version of Selenium since they switched to using the W3C protocol). |
Author
|
@forceedge01 Just a nudge for when you've got chance to have a look at this; would be nice to remove my local workaround to resolve this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When taking a screenshot, either directly or on failure, passing "current" as the window name argument is currently ignored by both php-webdriver and the dmore mink chrome driver (so has no effect), and causes a failure when used with the oleg-andreyev mink phpwebdriver extension (which checks to see if the window name is passed as a value other than null).
As neither php-webdriver (always using the "current" window handle) or the dmore mink chrome driver (uses it's own JS based method of resizing that doesn't use this value), removing this argument should have no detrimental effect on most (all) use cases.