execution_graph: harden report mask semantics - #94
Merged
Conversation
Make `ReportDetailMask` a composable bitmask before the reporting API settles. This adds `Default`, const union/intersection helpers, and the standard bitwise operator impls so callers can build detail masks without waiting for named constants for every combination. Honor the detail bits independently: requesting `WHY_PATH` no longer also fills `because_of` unless `BECAUSE_OF` is requested. The expanded tests cover `NONE`, `BECAUSE_OF`, `WHY_PATH`, and combined masks so this behavior stays explicit. Mark the public report output structs as `non_exhaustive` while the API is still early, allowing future report fields to be added without another breaking shape change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
ReportDetailMaska composable bitmask before the reporting API settles. This addsDefault, const union/intersection helpers, and the standard bitwise operator impls so callers can build detail masks without waiting for named constants for every combination.Honor the detail bits independently: requesting
WHY_PATHno longer also fillsbecause_ofunlessBECAUSE_OFis requested. The expanded tests coverNONE,BECAUSE_OF,WHY_PATH, and combined masks so this behavior stays explicit.Mark the public report output structs as
non_exhaustivewhile the API is still early, allowing future report fields to be added without another breaking shape change.