imaging: add support for scene pictures and images - #42
Open
jrmoulton wants to merge 2 commits into
Open
Conversation
jrmoulton
force-pushed
the
push-rovxpmlozvqo
branch
from
April 20, 2026 03:59
a608e69 to
29f369f
Compare
jrmoulton
force-pushed
the
push-rovxpmlozvqo
branch
from
April 20, 2026 05:20
29f369f to
46caa77
Compare
waywardmonkeys
pushed a commit
that referenced
this pull request
Jul 6, 2026
Replace the fork-commit framing in the multi-version lanes section and add a full review of PR #42: core handle design assessment, backend cache findings (tolerance keys, hybrid per-miss renderer construction, atlas weak-purge gap, resize cache flush), the shared weak-keyed cache ask, testing gaps, and a rebase plan against the 19 newer main commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XWiMSSaBKYB7by3KHzyij2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Arc backed handles for pictures and images which more or less map to SkPicture and SkImage where the intent of the picture is for the backend to retain an accelerated structure of some sort for the scene and the intent of the image is for the backend to retain a rasterized image of the scene (although the backend may choose the method of implementation). The backends are expected to keep weak references to the handles and may clear the associated data when there are no more strong references.