Skip to content

Remove unneeded winit dependencies - #76

Open
melix99 wants to merge 1 commit into
forest-rs:mainfrom
melix99:winit-no-csd
Open

Remove unneeded winit dependencies#76
melix99 wants to merge 1 commit into
forest-rs:mainfrom
melix99:winit-no-csd

Conversation

@melix99

@melix99 melix99 commented Aug 2, 2025

Copy link
Copy Markdown

I noticed that crates using this project as a dependency pulled sctk-adwaita, which seems unnecessary for this crate.

@waywardmonkeys

Copy link
Copy Markdown
Collaborator

Maybe our dependency shouldn’t enable any features and we should enable them only as a dev dependency?

thoughts, @xorgy ?

@melix99

melix99 commented Aug 3, 2025

Copy link
Copy Markdown
Author

If I don't enable at least x11 or wayland on Linux, I can't build the project because of this error:

   Compiling winit v0.30.10
error: The platform you're compiling for is not supported by winit
  --> /var/home/melix/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/winit-0.30.10/src/platform_impl/mod.rs:78:1
   |
78 | compile_error!("The platform you're compiling for is not supported by winit");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@melix99

melix99 commented Aug 3, 2025

Copy link
Copy Markdown
Author

See rust-windowing/winit#3174

@xorgy

xorgy commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

Maybe for now just make it use wayland and add a comment in the Cargo.toml that links to the winit issue for this. Sorry it's been so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants