Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates ArgMojo’s core code and tooling configuration to be compatible with Mojo v1.0.0b1.
Changes:
- Bump Pixi environment (project version + Mojo dependency) to Mojo
1.0.0b1and refresh the lockfile. - Migrate string-length usage from
len(String)toString.byte_length()across core parsing/help code. - Update reflection and type constraints for Mojo 1.0 (
reflect[T]()API,ImplicitlyDestructiblebounds, andthinfunction pointers for stored handlers).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_help.mojo | Updates help-output parsing logic to use byte_length() for Mojo 1.0 string APIs. |
| src/argmojo/utils.mojo | Migrates string length checks to byte_length() and updates numeric/similarity helpers accordingly. |
| src/argmojo/parse_result.mojo | Switches alignment/emptiness checks to byte_length() for Mojo 1.0 compatibility. |
| src/argmojo/parsable.mojo | Updates trait bounds and replaces deprecated struct_field_* reflection with reflect[Self]() API. |
| src/argmojo/command.mojo | Updates response-file parsing length checks and changes auto-dispatch handler storage/signature to thin function pointers. |
| src/argmojo/argument.mojo | Updates compile-time validation to use byte_length() for Mojo 1.0 string semantics. |
| src/argmojo/argument_wrappers.mojo | Adds ImplicitlyDestructible bounds and switches type-name reflection to reflect[T]().name(). |
| pixi.toml | Bumps project version and pins Mojo to ==1.0.0b1. |
| pixi.lock | Updates locked artifacts to Mojo 1.0.0b1 (+ related package updates). |
| docs/changelog.md | Adds an unreleased note documenting Mojo 1.0.0b1 compatibility changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates ArgMojo’s core code and tooling configuration to be compatible with Mojo v1.0.0b1.
Changes:
1.0.0b1and refresh the lockfile.len(String)toString.byte_length()across core parsing/help code.reflect[T]()API,ImplicitlyDestructiblebounds, andthinfunction pointers for stored handlers).