Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors BigInt.from_integral_scalar() to remove most dtype-specific branching by (1) computing the magnitude in an unsigned dtype of the same width and (2) extracting 32-bit limbs in a generic, compile-time unrolled loop. It also introduces a shared unsigned_counterpart() helper and updates the bigint enhancement plan document to describe the simplified approach.
Changes:
- Add
decimo.utility.unsigned_counterpart[dtype]()to map signed integral dtypes to their equal-width unsigned equivalents. - Rewrite
BigInt.from_integral_scalar()to compute sign/magnitude generically and peelBITS_PER_WORDchunks in a single loop. - Update
docs/plans/bigint_enhancement.mdwith notes about simplifyingfrom_integral_scalarunder limb-width parameterization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/decimo/utility.mojo |
Adds unsigned_counterpart() helper for mapping signed integral dtypes to unsigned counterparts. |
src/decimo/bigint/bigint.mojo |
Replaces dtype-by-dtype limb extraction with a generic magnitude + peel-loop implementation. |
docs/plans/bigint_enhancement.md |
Documents the refactor opportunity and considerations around limb-width parameterization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
BigInt.from_integral_scalar()to remove most dtype-specific branching by (1) computing the magnitude in an unsigned dtype of the same width and (2) extracting 32-bit limbs in a generic, compile-time unrolled loop. It also introduces a sharedunsigned_counterpart()helper and updates the bigint enhancement plan document to describe the simplified approach.Changes:
decimo.utility.unsigned_counterpart[dtype]()to map signed integral dtypes to their equal-width unsigned equivalents.BigInt.from_integral_scalar()to compute sign/magnitude generically and peelBITS_PER_WORDchunks in a single loop.docs/plans/bigint_enhancement.mdwith notes about simplifyingfrom_integral_scalarunder limb-width parameterization.