Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds factorial support for Decimo’s arbitrary-precision numeric types, exposing factorial() as a standalone function in new special modules and as instance methods on BigInt and BigDecimal.
Changes:
- Added
decimo.bigint.special.factorial()and wired it intoBigInt.factorial(). - Added
decimo.bigdecimal.special.factorial(x, precision=0)(exact and rounded modes) and wired it intoBigDecimal.factorial(...). - Updated module documentation to include the new
specialmodules (andnumber_theoryin the BigInt package doc).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/decimo/bigint/special.mojo | Introduces factorial(BigInt) implementation and input cap. |
| src/decimo/bigint/bigint.mojo | Adds BigInt.factorial() method and imports the new special module. |
| src/decimo/bigint/init.mojo | Updates BigInt package module listing/documentation. |
| src/decimo/bigdecimal/special.mojo | Introduces factorial(BigDecimal, precision) with exact and rounded paths. |
| src/decimo/bigdecimal/bigdecimal.mojo | Adds BigDecimal.factorial(...) method and imports the new special module; minor docstring tweak. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds factorial support for Decimo’s arbitrary-precision numeric types, exposing
factorial()as a standalone function in newspecialmodules and as instance methods onBigIntandBigDecimal.Changes:
decimo.bigint.special.factorial()and wired it intoBigInt.factorial().decimo.bigdecimal.special.factorial(x, precision=0)(exact and rounded modes) and wired it intoBigDecimal.factorial(...).specialmodules (andnumber_theoryin the BigInt package doc).