fix: post refuses to sign as the wrong identity - #47
Merged
Conversation
The signer that answers is whichever bunker happens to be running, and a note is as much an identity claim as a document is. publish and unpublish have refused a mismatch since 0.16.2; post had no guard at all. The failure it prevents is a quiet one and the setup for it is ordinary: publish a hole under a project key, leave the bunker up, write a note, and the note goes out under the project rather than under you. That is the 2026-08-06 mistake pointed the other way. --as costs nothing, because get_public_key is not a signing operation.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishandunpublishhave taken--assince 0.16.2.postdid not, so the identity a note claims was whichever bunker happened to be answering.The setup for getting it wrong is completely ordinary: publish a hole under a project key, leave the bunker running, write a note, and the note goes out under the project rather than under you. Same shape as the 2026-08-06 mixup, pointed the other way.
--ascosts nothing, sinceget_public_keyis not a signing operation.