Skip to content

ci: make the release publishable and the typecheck real #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clintberry merged 1 commit into from
Aug 4, 2026
Merged

ci: make the release publishable and the typecheck real #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ jobs:
- name: ESLint
run: npm run lint
- name: TypeScript typecheck
run: npx tsc --noEmit
# Build mode, not a bare --noEmit: the root tsconfig is solution-style
# ("files": [] plus project references), so `tsc --noEmit` compiles zero
# files and exits 0 no matter what. This step checked nothing until now.
run: npx tsc -b --noEmit
- name: Frontend build
run: npm run build
- name: Go tests (integration enabled via TEST_DATABASE_URL)
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,20 @@ jobs:
- name: ESLint
run: npm run lint
- name: TypeScript typecheck
run: npx tsc --noEmit
# Build mode, not a bare --noEmit: the root tsconfig is solution-style
# ("files": [] plus project references), so `tsc --noEmit` compiles zero
# files and exits 0 no matter what. This step checked nothing until now.
run: npx tsc -b --noEmit
- name: Go tests (integration enabled via TEST_DATABASE_URL)
working-directory: server
env:
TEST_DATABASE_URL: postgres://deuce:deuce@localhost:5432/deuce?sslmode=disable
run: go test ./...
# -p 1 runs PACKAGES serially, matching ci.yml. The db, handler and
# sshproxy integration packages each reset the schema on the SAME
# database, so running them in parallel fails outright. Without this
# the release cannot publish — the test job dies before the image is
# ever built.
run: go test -p 1 ./...

frontend_build:
if: github.repository == 'forgeutah/deuce'
Expand Down
Loading