Change build to use es6 modules#32
Open
jaimedp wants to merge 2 commits into
Open
Conversation
narenranjit
suggested changes
Apr 30, 2018
| * }); | ||
| * | ||
| * | ||
| * @name map(data, options) |
There was a problem hiding this comment.
Is the name used anywhere? The signature differs from the actual one here?
Contributor
Author
There was a problem hiding this comment.
The jsdoc entry is a reflection of how the visualization should be used and is for generation of the documentation, and not how the signature of the renderer function is defined... it may be a bit strange/confusing that is right before the definition of the renderer, but you'd not be calling that function directly.
| .smallStatesCallouts() | ||
|
|
||
| .tooltip() | ||
| // .marker([[-122.490402, 37.786453]], { |
Contributor
Author
There was a problem hiding this comment.
Removed changes to this file... is file is more a sandbox to play with the lib locally than anything that is published
Contributor
Author
|
Note that for this changes to work, we need to publish contour to npm as this lib has a dependency on "contour@2.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.