Conversation
added 2 commits
April 24, 2017 11:20
…tialization summary of options
…ges supported didn’t seem like this needed its own pr.
narenranjit
reviewed
Apr 26, 2017
| * **Example** | ||
| * | ||
| * var cm = new F.manager.ChannelManager(); | ||
| * var cm = new F.manager.ChannelManager({shareConnection: true}); |
Contributor
There was a problem hiding this comment.
I think the default example should always be the simplest - var cm = new F.manager.ChannelManager(). If it turns out that shareConnection indeed does work we'll just make that the default.
Contributor
Author
|
per discussion -- will make changes to this pr after https://issues.forio.com/browse/EPICENTER-2940 is complete (and we've confirmed ok to change the default for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.