fix(pylon,theatron,diaporeia): resolve all kanon lint violations#1919
Merged
forkwright merged 1 commit intomainfrom Mar 21, 2026
Merged
fix(pylon,theatron,diaporeia): resolve all kanon lint violations#1919forkwright merged 1 commit intomainfrom
forkwright merged 1 commit intomainfrom
Conversation
|
Consider splitting into smaller PRs for easier review. Not a blocker, just a signal. |
Apply Rust 2024 edition patterns across the three interface-layer crates: - pub → pub(crate) for internal items, with .kanon-lint-ignore for re-exports - #[allow(lint)] → #[expect(lint)] with reason strings - as casts → try_from/try_into where applicable - #[must_use] on pub functions returning Result/Option - Import ordering per standards (std → external → crate) - test_ prefix → behavior-driven names for test helpers - tokio::spawn .instrument() multi-line false positives → ignore file - Struct field grouping (MemoryFact, TabState) for >12 fields Per-crate .kanon-lint-ignore files document all legitimate suppressions with WHY comments. All three crates pass kanon lint with 0 violations.
forkwright
force-pushed
the
fix/lint-interface
branch
from
086d477 to
0512211
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub→pub(crate)for internal items,#[allow]→#[expect]with reasons,ascasts →try_from/try_into, import reordering,#[must_use]annotations, test naming.kanon-lint-ignorefiles documenting all legitimate suppressions with WHY comments (re-exported pub items, multi-line.instrument()false positives, TUI view indexing, terminal coordinate casts)Validation
kanon lint crates/pylon— 0 violationskanon lint crates/theatron— 0 violationskanon lint crates/diaporeia— 0 violationscargo check --workspace— cleancargo test --workspace— all tests passcargo fmt --all -- --check— cleanTest plan
.kanon-lint-ignoreentries have accurate WHY justifications