FIO-11157: fix protected-eval enclosed in default object#22
Merged
brendanbond merged 1 commit intomasterfrom Feb 25, 2026
Merged
FIO-11157: fix protected-eval enclosed in default object#22brendanbond merged 1 commit intomasterfrom
brendanbond merged 1 commit intomasterfrom
Conversation
brendanbond
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-11157
Description
What changed?
added "export: default" to the output of the webpack config. This allows webpack to know were the protected-eval object is located on default exports. Also made some quality of life changes to the webpack config and tsconfig that align more with what a library that will be bundled into a browser expects
Why have you chosen this solution?
Before when embedding protected-eval.js you would have to call it like so
window['protected-eval'].defaultThis is because we are exporting our library with
adding "export: default" to the webpack configuration allows webpack to correctly put the protected-eval object on the browsers window object
Breaking Changes / Backwards Compatibility
With this change protected eval will now be correctly added as a module into the portal app. It looks like this will break customers that utilize custom javascript
Dependencies
N/A
How has this PR been tested?
manually tested
Checklist: