Update framels 0.7.7#21
Merged
Merged
Conversation
246bea9 to
57cce0e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the framels binding to version 0.7.7 and aligns the Python packaging and CI workflows with newer tooling.
- Bumps Rust and Python package versions and pyo3 dependency to match framels 0.7.7
- Adjusts lib.rs to use the new
BoundAPI and reformats chained calls - Revamps CI matrix for multi-arch builds, adds a
musllinuxjob, and upgrades GitHub Action versions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Reformatted chained calls and updated #[pymodule] signature |
| pyproject.toml | Added version/description/readme, moved build-system, added dev group |
| README.md | Updated benchmark notes and extended table with 100-path results |
| Cargo.toml | Bumped crate and dependency versions |
| .github/workflows/CI.yml | Expanded build matrix, bumped action versions, added musllinux job |
Comments suppressed due to low confidence (2)
src/lib.rs:9
- [nitpick] Rename the variable
valto something more descriptive such aspathsorlisted_pathsto improve readability.
let val: Vec<PathBuf> = basic_listing(Paths::from(list_paths), multithreaded)
src/lib.rs:34
- [nitpick] Consider renaming the parameter
mtomoduleorpy_modulefor clearer intent in the module initializer.
fn py_framels(m: &Bound<'_, PyModule>) -> PyResult<()> {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.