Skip to content

Update framels 0.7.7#21

Merged
doubleailes merged 1 commit into
mainfrom
update_framels_0.7.7
May 18, 2025
Merged

Update framels 0.7.7#21
doubleailes merged 1 commit into
mainfrom
update_framels_0.7.7

Conversation

@doubleailes

Copy link
Copy Markdown
Collaborator

No description provided.

@doubleailes doubleailes requested a review from Copilot May 18, 2025 08:45
@doubleailes doubleailes force-pushed the update_framels_0.7.7 branch from 246bea9 to 57cce0e Compare May 18, 2025 08:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the framels binding to version 0.7.7 and aligns the Python packaging and CI workflows with newer tooling.

  • Bumps Rust and Python package versions and pyo3 dependency to match framels 0.7.7
  • Adjusts lib.rs to use the new Bound API and reformats chained calls
  • Revamps CI matrix for multi-arch builds, adds a musllinux job, and upgrades GitHub Action versions

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib.rs Reformatted chained calls and updated #[pymodule] signature
pyproject.toml Added version/description/readme, moved build-system, added dev group
README.md Updated benchmark notes and extended table with 100-path results
Cargo.toml Bumped crate and dependency versions
.github/workflows/CI.yml Expanded build matrix, bumped action versions, added musllinux job
Comments suppressed due to low confidence (2)

src/lib.rs:9

  • [nitpick] Rename the variable val to something more descriptive such as paths or listed_paths to improve readability.
let val: Vec<PathBuf> = basic_listing(Paths::from(list_paths), multithreaded)

src/lib.rs:34

  • [nitpick] Consider renaming the parameter m to module or py_module for clearer intent in the module initializer.
fn py_framels(m: &Bound<'_, PyModule>) -> PyResult<()> {

@doubleailes doubleailes merged commit 8652d81 into main May 18, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants