Repository navigation
feat: update app container after image pull - #33
Conversation
|
Possible duplicate (likely confidence): #32 PR #32 and PR #33 implement substantially the same intended change: both add scripts/update-docker.sh with Docker Compose v2/v1 detection, pull the latest app image, then run Related item: #32 This is an automated similarity suggestion. The item has not been closed automatically. |
|
Automated review has started. I am checking this pull request now. |
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: forumlify-next-client-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Automated review
Mode: normal
Comment
Small, sensible change: the helper pulls the app image and recreates only the app container via up -d --no-deps app, leaving PostgreSQL and its volume intact, with proper set -Eeuo pipefail and Docker Compose v1/v2 detection. Before merge, confirm the script has the executable bit (see inline note) and that the compose service is actually named app, since pull app/up -d --no-deps app will fail otherwise. No application code, schema, build, or test behavior is affected.
Result for maintainers
No blocking issues found. The Docker update helper and README changes align with the project's Compose-based deployment and do not touch application code, schema, or tests.
Model decision: safe to merge
Applied review policy: allow
Final status: safe to merge
Required changes: 0
Review notes: 1
|
@bot what does this pr change |
|
This PR makes Docker image updates deterministic. In short: New script:
README update
The key behavior change: previously the docs told users to pull and then do |
感谢你为 Forumlify 提交贡献!/ Thank you for contributing to Forumlify!
目标分支 / Target branch
版本信息 / Version info
变更内容 / What does this PR do?
scripts/update-docker.sh,兼容 Docker Compose v2(docker compose)和 v1(docker-compose)。app镜像,再执行up -d --no-deps app,由 Compose 在镜像变化时自动重新创建应用容器。download/install.sh。/ Add a Docker update helper compatible with Compose v1 and v2. It pulls the latest app image and then runs
up -d --no-deps app, allowing Compose to recreate the app when the image changes. The database container and volume are left untouched.动机 / Motivation
当前只拉取镜像或重新启动的操作不够明确,容易继续使用旧容器。统一更新命令后,应用容器会根据镜像变化自动刷新,同时不重建数据库。
/ Make image updates deterministic while keeping the PostgreSQL container and volume intact.
测试 / Testing
npm run build,仅 next 分支 / next branch only)截图 / Screenshots
不适用 / Not applicable(无 UI 改动 / no UI changes)
检查清单 / Checklist