build: Move triton to an optional dependency#146
Merged
chichun-charlie-liu merged 4 commits intofoundation-model-stack:mainfrom Jun 24, 2025
Merged
build: Move triton to an optional dependency#146chichun-charlie-liu merged 4 commits intofoundation-model-stack:mainfrom
chichun-charlie-liu merged 4 commits intofoundation-model-stack:mainfrom
Conversation
Collaborator
Author
|
So apparently, I have disabled the triton tests on CI/CD. There are no GPUs, so this is expected behavior. |
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
chichun-charlie-liu
approved these changes
Jun 23, 2025
Collaborator
|
triton assertion error will be addressed by #141 , other than that, lgtm |
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
chichun-charlie-liu
approved these changes
Jun 24, 2025
bcee5f3
into
foundation-model-stack:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This change moves triton to being an optional package. An additional guard was added, along with minor changes to the test script.
Related issues or PRs
N/A
How to verify the PR
Was the PR tested
Triton tests are now skipped on CI/CD rather than passing via a quick return.
Locally, on my machine I am getting 9x failures from one of the tests:
Checklist for passing CI/CD:
git commit -signoffor equivalenttox -e fixtox -e linttox -e spellchecktox -e unitNote: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.