Add support for HSMs#7
Merged
ricardosalveti merged 7 commits intofoundriesio:masterfrom Jul 16, 2020
Merged
Conversation
Signed-off-by: Andy Doan <andy@foundries.io>
This lets us connect to the device-gateway via TLS Signed-off-by: Andy Doan <andy@foundries.io>
We are going to update this in a way that probably can't be merged upstream. This was copied from: https://github.com/ethereum/go-ethereum/blob/02cea2330d6b4822b43a7fbaeacc12ddc8e8b1db/crypto/ecies/ecies.go Signed-off-by: Andy Doan <andy@foundries.io>
This required some golang tidy updates and I removed the unused functions. Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
Signed-off-by: Andy Doan <andy@foundries.io>
Member
Author
|
@ricardosalveti - unit tests aren't going to be able to pass because of the required patch. |
This is a temporary work-around while the PR gets sorted out: ThalesGroup/crypto11#70 Signed-off-by: Andy Doan <andy@foundries.io>
ricardosalveti
approved these changes
Jul 16, 2020
Member
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to fioconfig for working with HSMs. It requires a patch to crytpo11:
ThalesGroup/crypto11#70