Skip to content

chore: clarify IERC7540 deposit request comments #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BonyHanter83 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: clarify IERC7540 deposit request comments #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/interfaces/IERC7540.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface IERC7540Operator {
function setOperator(address operator, bool approved) external returns (bool);

/**
* @dev Returns `true` if the `operator` is approved as an operator for an `controller`.
* @dev Returns `true` if the `operator` is approved as an operator for a `controller`.
*
* @param controller The address of the controller.
* @param operator The address of the operator.
Expand All @@ -41,12 +41,11 @@ interface IERC7540Deposit is IERC7540Operator {
address indexed controller, address indexed owner, uint256 indexed requestId, address sender, uint256 assets
);
/**
* @dev Transfers assets from sender into the Vault and submits a Request for asynchronous deposit.
* @dev Transfers assets from owner into the Vault and submits a Request for asynchronous deposit.
*
* - MUST support ERC-20 approve / transferFrom on asset as a deposit Request flow.
* - MUST revert if all assets cannot be requested for deposit.
* - owner MUST be msg.sender unless some unspecified explicit approval is given by the caller,
* approval of ERC-20 tokens from owner to sender is NOT enough.
* - owner MUST be msg.sender unless owner has approved msg.sender as an operator.
* - MUST revert if all assets cannot be requested for deposit or mint.
*
* @param assets the amount of deposit assets to transfer from owner
* @param controller the controller of the request who will be able to operate the request
Expand Down