Skip to content

⚡ Bolt: Optimize hot-path AST traversals via explicit stacks#87

Open
tachyon-beep wants to merge 1 commit into
mainfrom
bolt-ast-traversal-optimization-9510852170311381834
Open

⚡ Bolt: Optimize hot-path AST traversals via explicit stacks#87
tachyon-beep wants to merge 1 commit into
mainfrom
bolt-ast-traversal-optimization-9510852170311381834

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

💡 What:
Replaced recursive yield from calls with explicit stack-based traversals in heavily-used AST walking functions (_walk_own, _walk_own_non_stmt_children, walk_node, and _iter_l2_body_nodes). Inlined ast.iter_child_nodes behavior directly across _fields checks to cut out standard library overhead where applicable, and properly documented the optimizations.

🎯 Why:
Using deep recursive yield from in Python incurs generator chaining overhead which is costly for hot paths processing potentially deep Abstract Syntax Trees. Stacks avoid both RecursionError on highly nested statements and unnecessary execution slowdowns.

📊 Impact:
Benchmark measures showed roughly ~20% runtime reduction for own_nodes (e.g. from 7.33s to 5.93s over 100,000 runs in a test benchmark) and avoids recursion exhaustion, while retaining exactly the same lazy-yielding guarantees and correct DFS node evaluation order.

🔬 Measurement:
Tested and validated against the entire project's test suite ensuring that logic remains intact and nodes are emitted in identical left-to-right DFS order as make test correctly verifies. Run make test, make typecheck, and make lint confirming exact correctness without regressions.


PR created automatically by Jules for task 9510852170311381834 started by @tachyon-beep

Replaced recursive `yield from` calls with explicit stack traversal across `walk_node`, `_walk_own_non_stmt_children`, `_walk_own`, and `_iter_l2_body_nodes`. This avoids deep recursion limits and the performance overhead associated with python generator chaining during hot-path AST parsing. Retained depth-first traversal left-to-right order by correctly pushing the reversed child list elements into the LIFO stack.

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant