Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

Feat/create gulpset skeleton#28

Open
huyld wants to merge 22 commits into
masterfrom
feat/create-gulpset-skeleton
Open

Feat/create gulpset skeleton#28
huyld wants to merge 22 commits into
masterfrom
feat/create-gulpset-skeleton

Conversation

@huyld
Copy link
Copy Markdown

@huyld huyld commented Nov 14, 2018

In this PR

  • Change the package name from gulpset-skeleton to create-gulpset-skeleton
  • Create bootstrap script. It will
    • validate project name to follow npm naming rules and avoid conflict with existing packages.
    • copy skeleton files and directory from the package create-gulpset-skeleton into new project.
    • run yarn install to install all the dependencies listed within package.json.
  • Update README.md

To-dos

I see some rooms for improvement:

  • Validate project name to follow npm naming rules and avoid conflict with existing packages.
  • Colorize console message. Currently log and error message are the same color.
  • Isolate init script init.js. Currently it's in gulpset/. I think it should not be part of the skeleton.
  • After copy skeleton files and dirs, init script should run yarn install to install all the dependencies listed within package.json.
  • Generating package.json file for new project with devDependencies copied from gulpset-skeleton package.json. We cannot reuse the our package.json because of specific configuration such as name, author, license, etc.
  • Update current README.md file of fourdigit/gulpset.

@huyld huyld self-assigned this Nov 14, 2018
@huyld huyld changed the title [WIP] Feat/create gulpset skeleton Feat/create gulpset skeleton Nov 16, 2018
@huyld huyld requested a review from TakuyaAbe November 16, 2018 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant