Conversation
…N responses - Updated getGenerate, postGenerate, and vision methods to return either a string or a JSON object based on the jsonMode parameter. - Introduced parseJson and sanitizeJson private methods for handling JSON parsing and sanitization. - Improved type safety by allowing generic return types for methods in the TextService interface.
- Implemented tests for getGenerate, postGenerate, and vision methods to validate JSON response parsing and sanitization. - Added scenarios for handling malformed JSON and already parsed JSON objects. - Ensured error handling for invalid JSON responses after sanitization.
…just request builder - Removed the prompt property from TextGenerationGetParams interface for cleaner structure. - Updated TextGenerationGetRequestBuilder to include prompt as part of the generic type, enhancing type safety and clarity in request handling. - Adjusted test cases to reflect the changes in the request parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements comprehensive JSON response handling and enhances error management across all service methods. Key improvements:
jsonMode=trueChanges
JSON Response Handling
handleResponseutility for consistent JSON parsingTesting
Verification
jsonMode=truejsonMode=falseCloses #8