make sure app_data is bytes, not str#3
Draft
jardous wants to merge 1 commit intofr33n0w:mainfrom
Draft
Conversation
Author
|
does not really solve the issue :/ [DEBUG] Received announce from with app_data: b'\x91\xa5Ditch' Happens here: |
Author
|
ok - fixed the issue: https://github.com/markqvist/LXMF/compare/master...jardous:patch-1?expand=1 But no idea how to PR... :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix
LXMF.display_name_from_app_data() internally calls .decode() on its argument, which only works on bytes. In newer versions of RNS/LXMF, app_data can arrive (or be recalled) as a str instead of bytes, triggering the 'str' object has no attribute 'decode' error.