deps: Bump Fluent crates to latest minor releases#335
Open
alerque wants to merge 1 commit intoframesurge:mainfrom
Open
deps: Bump Fluent crates to latest minor releases#335alerque wants to merge 1 commit intoframesurge:mainfrom
alerque wants to merge 1 commit intoframesurge:mainfrom
Conversation
Member
|
Much appreciated! Yes, CI is completely dead right now, will test this locally and then merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just released a breaking version (minor version because we're stuck in zero-ver teritory) to the upstream Fluent crate(s). I see they are used here, but I don't think any of the upstream changes will actually be breaking for this project so a simple bump should be sufficient.
I was not able to test this due to build/check/test failures that seem to be unrelated to this bump. Given that your CI suite seems to be all red right now I suspect the repo is just in a broken state right now. You could test this rebased against something that is known to work.