Skip to content

Refactored xml parsing vulnerability #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnpotters1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactored xml parsing vulnerability #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d707cfa
fix: refactored xml parsing vulnerability
stijnpotters1 Jan 23, 2026
bb38fc8
fix: removed getter
stijnpotters1 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/main/java/org/frankframework/flow/project/Project.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,7 @@ public void setConfigurationXml(String filepath, String xmlContent) {
}
}

public ProjectSettings getProjectSettings() {
return this.projectSettings;
}

public boolean isFilterEnabled(FilterType type) {
public boolean isFilterEnabled(FilterType type) {
return projectSettings.isEnabled(type);
}

Expand Down Expand Up @@ -92,15 +88,15 @@ public boolean updateAdapter(String configurationName, String adapterName, Strin
}

private Document parseXml(String xmlContent) throws Exception {
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
DocumentBuilderFactory factory = XmlSecurityUtils.createSecureDocumentBuilderFactory();
factory.setIgnoringComments(true);
factory.setNamespaceAware(true);
DocumentBuilder builder = factory.newDocumentBuilder();
return builder.parse(new ByteArrayInputStream(xmlContent.getBytes()));
}

private Node parseNewAdapter(Document configDoc, String newAdapterXml) throws Exception {
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
DocumentBuilderFactory factory = XmlSecurityUtils.createSecureDocumentBuilderFactory();
factory.setIgnoringComments(true);
factory.setNamespaceAware(true);
DocumentBuilder builder = factory.newDocumentBuilder();
Expand Down
Loading