fix: handle absent serialNo column in filter input #218 #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use getStandardColumnCount to dynamically determine if the first column shoould be disabled, preventing data columns from being incorrectly locked when serialNoColumn is false. ✅ Closes: frappe#218
Author
|
Hi @iamejaaz, I'm following up on this PR which addresses issue #218. I have implemented the recommended change to use getStandardColumnCount() to dynamically handle cases where serialNoColumn is set to false. This ensures that filter inputs for data columns are not incorrectly disabled. The changes are minimal and have no conflicts with the base branch. Could you please review this when you have a moment? Thanks! |
Member
|
@sokumon could you please check this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use getStandardColumnCount to dynamically determine if the first column shoould be disabled, preventing data columns from being incorrectly locked when serialNoColumn is false.
✅ Closes: #218